934 review tests on createslf package #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/8521649016/attempts/1https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/8521649016/attempts/1 Accepted in #942 (comment) Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Going to fix the "no visible binding" issues in this branch. |
sc_send_lca no longer available in sc_client_lookup and hence corrupt the targets pipeline
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/8541148819/attempts/1 Accepted in #942 (comment) Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@check-spelling-bot: Could not perform request. Request did not change repository content. Maybe someone already applied these changes? See log for details. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit f9ffcf9.
This comment has been minimized.
This comment has been minimized.
fix "ignored-expect-variant"
This comment has been minimized.
This comment has been minimized.
fix "ignored-expect-variant"
|
Finally, all checks have passed! all green! Ready for review |
Jennit07
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.